> Uh. Note it's not exactly helpful to change algorithms between > reviews, that makes it > just harder :/ > > Btw, I notice you use post-dominance info. Note that we generally do > not keep that > up-to-date with CFG manipulations (and for dominators fast queries are > disabled). > Probably the way we walk & transform loops makes this safe but it's something > to > remember when extending that. Possibly doing analysis of all candidates first > and then applying the transform for all wanted cases would avoid this (and > maybe > also can reduce the number of update_ssa calls). I guess this can be done as > followup.
Ok. Thanks for the suggestion. Feng
