Hi Rainer,
Rainer Orth <r...@cebitec.uni-bielefeld.de> wrote:
Rainer Orth <r...@cebitec.uni-bielefeld.de> wrote:
No idea about Darwin/PowerPC though.
Right now, anything < 10.4 is not a viable host (without jumping through
a lot of hoops, regardless of the c99 requirements)...
… but It would be good to continue to support these earlier versions as
cross-
targets (however, it’s low on my priority list to do any serious lifting
there).
ok, good to know.
If pre-10.3 is supposed to be
supported, the -mmacosx-version-min=10.3 probably needs to go into
rs6000/darwin.h first. Iain?
I’m not quite sure what you’re proposing here (probably missing something
obvious).
At the moment, gcc/testsuite/lib/target-supports.exp
(add_options_for_c99_runtime) adds -mmacosx-version-min=10.3 to the
testcase flags on powerpc-*-darwin*. Since, as Joseph mentioned, gcc
now defaults to -std=gnu11 (which implies a C99 runtime), this (or
something similar) would always be needed now (unless someone forces,
say, -std=c90) and should be handled in the Darwin/PowerPC driver code,
not just the testsuite.
The driver has the following rules:
* if the user puts -mmacosx-version-min= on the command line that trumps all
* else we pick a default using the following priority.
1. MACOSX_DEPLOYMENT_TARGET env var.
2. (native)
- what the kernel returns for the system version.
(cross)
- what was set at configure time for DEF_MIN_OSX_VERSION (which will
be >= 10.3.9 as things stand)
So, of course, if we were hosted on 10.2.8 - that would create a problem
(2, native)
but if the system doesn’t have c99 support, that’s a problem anyway.
Otherwise, deliberate mis-configuration or passing -mmacosx-version-min= in
RUNTESTFLAGS … but we don’t need to support that.
Therefore, I suspect that the addition of the "-mmacosx-version-min=10.3”
is not
necessary and is a hang-over from older toolchains.
Perhaps, we could have a target_supports_c99 (maybe we already do), since
it’s
feasible that some embedded platforms might also want that exclusion - that
would
cover earlier Darwin “automagically” assuming folks remember to apply it.
In any event, there’s no need to hold up fixing this issue,
If there’s any fallout from it on powerpc-darwin9, I should pick it up
quite quickly, since
it’s tested regularly.
thanks,
Iain
