Hi Rainer,
Rainer Orth <r...@cebitec.uni-bielefeld.de> wrote:
Hi Joseph,
On Wed, 9 Oct 2019, Rainer Orth wrote:
the new test FAILs on Solaris/x86, both 32 and 64-bit:
FAIL: gcc.dg/torture/builtin-fp-int-inexact-c2x.c -O0 execution test
FAIL: gcc.dg/torture/builtin-fp-int-inexact-c2x.c -O1 execution test
FAIL: gcc.dg/torture/builtin-fp-int-inexact-c2x.c -O2 execution test
FAIL: gcc.dg/torture/builtin-fp-int-inexact-c2x.c -O2 -flto
execution test
FAIL: gcc.dg/torture/builtin-fp-int-inexact-c2x.c -O2 -flto
-flto-partition=none execution test
FAIL: gcc.dg/torture/builtin-fp-int-inexact-c2x.c -O3 -g execution
test
The test aborts. This happens because dg-add-options c99_runtime
appends -std=c99 to the options, yielding -std=c2x -std=c99. If I
manually omit the -std=c99, the test PASSes. I'm uncertain yet how to
handle this. Maybe prepending -std=c99 is an option, but that may well
break other tests...
Since the default standard is now gnu11, I'd hope that dg-add-options
c99_runtime doesn't actually need to add any options at all. (Unless
there are tests using it with an explicit pre-C99 standard, which would
seem rather nonsensical.)
sometimes one misses the obvious ;-) I'll give the Solaris bootstrap a
try with the Solaris handling in add_options_for_c99_runtime removed.
No idea about Darwin/PowerPC though.
Right now, anything < 10.4 is not a viable host (without jumping through
a lot of hoops, regardless of the c99 requirements)...
… but It would be good to continue to support these earlier versions as
cross-
targets (however, it’s low on my priority list to do any serious lifting
there).
If pre-10.3 is supposed to be
supported, the -mmacosx-version-min=10.3 probably needs to go into
rs6000/darwin.h first. Iain?
I’m not quite sure what you’re proposing here (probably missing something
obvious).
Once this is resolved, all uses of dg-add-options c99_runtime in the
testsuite can go.
cheers
Iain
