On 7/30/19 7:52 AM, Uros Bizjak wrote: > On Thu, Jul 25, 2019 at 7:34 PM Peter Bergner <berg...@linux.ibm.com> wrote: >>> +#define DRIVER_SELF_SPECS SUBTARGET_DRIVER_SELF_SPECS >>> + >>> +#ifndef SUBTARGET_DRIVER_SELF_SPECS >>> +# define SUBTARGET_DRIVER_SELF_SPECS >>> +#endif > > Shouldn't we swap these two defines, so we always get SUBTARGET_D_S_S > defined first? Like: > > #ifndef SUBTARGET_DRIVER_SELF_SPECS > # define SUBTARGET_DRIVER_SELF_SPECS "" > #endif > > #define DRIVER_SELF_SPECS SUBTARGET_DRIVER_SELF_SPECS
That's the way I would have coded it myself, but when I looked at the other arches handling of spec defines, they all seemed to code it this way. Consider it swapped. Peter
