Hi Peter, On Thu, Jul 25, 2019 at 09:41:10AM -0500, Peter Bergner wrote: > On 7/25/19 2:50 AM, Iain Sandoe wrote: > > This will break Darwin which has used DRIVER_SELF_SPECS in config/darwin.h > > since they were introduced (and the equivalent before). > > > > This is because Darwin has driver self-specs common to the PPC and X86 > > ports. > > > > If this change is seen the way to go, then I guess one solution would be to > > rename the > > driver specs in config/darwin.h => SUBTARGET_DRIVER_SELF_SPECS*** and then > > put a dummy DRIVER_SELF_SPECS in i386/i386.h > > and append SUBTARGET_DRIVER_SELF_SPECS to both the i386.h and rs6000.h > > cases. (or something along those lines) > > Hi Iain, > > The patch below uses your suggestion. Does this work for you on x86 and ppc?
It all looks fine to me; if it works for Iain, it is approved for trunk, and thank you! Segher