Hi Hongtao,
>> as usual, the new effective-target keyword needs documenting in
>> sourcebuild.texi.
> Like this?
a couple of nits: first of all, your mailer seems to replace tabs by a
single space. Please fix this or attach the patch instead.
> Index: ChangeLog
> ===================================================================
> --- ChangeLog (revision 272668)
> +++ ChangeLog (working copy)
> @@ -1,3 +1,8 @@
> +2019-06-27 Hongtao Liu <hongtao....@intel.com>
> +
> + * doc/sourcebuild.texi: Document new effective target keyword
> + avx512vp2intersect.
Please include the sections you're modifying, something like
* doc/sourcebuild.texi (Effective-Target Keywords, Other
hardware attributes): Document avx512vp2intersect.
And please don't include the ChangeLog in the patch, but include it in
the mail proper: it won't apply due to date and context changes anyway.
Best review https://gcc.gnu.org/contribute.html where this is documented
besides other points of patch submission.
Besides, it's most likely useful to also review the GNU Coding
Standards, too, not only for ChangeLog formatting.
> Index: testsuite/ChangeLog
> ===================================================================
> --- testsuite/ChangeLog (revision 272668)
> +++ testsuite/ChangeLog (working copy)
> @@ -1,3 +1,11 @@
> +2019-06-27 Hongtao Liu <hongtao....@intel.com>
> +
> + * lib/target-supports.exp: Add
> + check_effective_target_avx512vp2intersect.
Use
* lib/target-supports.exp
(check_effective_target_avx512vp2intersect): New proc.
> + * gcc.target/i386/avx512vp2intersect-2intersect-1b.c: Add
> + dg-require-effective-target avx512vp2intersect.
Better:
* gcc.target/i386/avx512vp2intersect-2intersect-1b.c: Require
avx512vp2intersect.
but that's a matter of preference.
> Index: testsuite/gcc.target/i386/avx512vp2intersect-2intersect-1b.c
> ===================================================================
> --- testsuite/gcc.target/i386/avx512vp2intersect-2intersect-1b.c
> (revision 272668)
> +++ testsuite/gcc.target/i386/avx512vp2intersect-2intersect-1b.c (working
> copy)
> @@ -1,5 +1,6 @@
> /* { dg-do run } */
> /* { dg-options "-O2 -mavx512vp2intersect" } */
> +/* { dg-require-effective-target "avx512vp2intersect" } */
No need to quote avx512vp2intersect here and in the next test.
Ok with those nits fixed.
Thanks.
Rainer
--
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University
