On 16/06/19 20:58 +0200, Jakub Jelinek wrote:
On Sun, Jun 16, 2019 at 07:54:42PM +0100, Iain Sandoe wrote:
So, I guess, unless Jonathan has plans to add __cxa_rethrow_primary_exception
during the 10 time-frame, it’s correct to exclude the symbol anyway and we
should
bump the so version and apply trunk.
I don't understand why they've added it, it should be called
std::rethrow_exception and that is how it is called in libstdc++.
std::rethrow_exception was new in C++11, so maybe they wanted to be
able to use it in C++03 code as well? (Just a guess).
Actually, because the way in which interposing works for Darwin is different,
the only
symbol change in the library on Darwin is removing an "undefined dynamic
lookup".
So, for back-ports, I can could up with some Darwin-specific Makefike change
that
only adds the ASAN_HAS_CXA_RETHROW_PRIMARY_EXCEPTION=0 for Darwin.
So - OK for trunk with a bumped soname?
Yes.
(and a TODO to figure a Darwin-only backport)
Yeah.
Jakub
