On Fri, Jun 14, 2019 at 03:38:05PM +0100, Iain Sandoe wrote:
> For some Darwin versions the absence of the rethrow_primary_exception
> symbol causes almost all sanitizer tests to fail.
> 
> The following patch wraps it as suggested by Jakub in the PR trail, such that
> if the gate is not defined, it’s assumed to be available.

I wonder if we shouldn't bump libasan soname because of this, as this change
is removing an exported symbol from it.

Otherwise LGTM (but bumping soname would mean it is not backportable).

> 2019-06-14  Iain Sandoe  <i...@sandoe.co.uk>
> 
>       PR libsanitizer/87880
>       * asan/asan_interceptors.h:
>       (ASAN_INTERCEPT___CXA_RETHROW_PRIMARY_EXCEPTION): New.
>       * asan/Makefile.am (DEFS): Add 
>       ASAN_HAS_CXA_RETHROW_PRIMARY_EXCEPTION, defined to 0.
>       * asan/Makefile.in: Regenerated.

        Jakub

Reply via email to