Kugan Vivekanandarajah <kugan.vivekanandara...@linaro.org> writes: > +/* Return the preferred mem scale factor for accessing MEM_MODE > + of BASE which is optimized for SPEED. */
Maybe: /* Return the preferred index scale factor for accessing memory of mode MEM_MODE in the address space of pointer BASE. Assume that we're optimizing for speed if SPEED is true and for size otherwise. */ > @@ -3479,7 +3481,7 @@ add_iv_candidate_derived_from_uses (struct ivopts_data > *data) > data->iv_common_cands.truncate (0); > } > > -/* Adds candidates based on the value of USE's iv. */ > + /* Adds candidates based on the value of USE's iv. */ > > static void > add_iv_candidate_for_use (struct ivopts_data *data, struct iv_use *use) Stray change: the original is correct. > @@ -3500,6 +3502,26 @@ add_iv_candidate_for_use (struct ivopts_data *data, > struct iv_use *use) > basetype = sizetype; > record_common_cand (data, build_int_cst (basetype, 0), iv->step, use); > > + /* Compare the cost of an address with an unscaled index with the cost of > + an address with a scaled index and add candidate if useful. */ Should be two spaces after "." OK with those changes, thanks. OK for part 2 as well. Richard
