On 11/04/2011 11:48 AM, Jeff Law wrote:
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 11/03/11 17:50, Andrew MacLeod wrote:
The testsuite changes are split into 3 parts.
This part is all the new testsuite entries for testing the atomics
for functionality. ie, make sure they work as expected, and
generate errors when expected
I spot checked various tests and it looks pretty good to me.
Given the duplications in the the tests I wondered if we could play
tricks with macros or something to simplify the testfiles, but I doubt
it's worth the effort. Certainly not required.
I originally did that, but then changed it and decided it was better
this way. The point of tests is to help you figure out what has
failed... With all the macro packing and compression, it took more
effort to figure out what had gone wrong, and required multiple files.
Now its a simple self contained testcase you just run.
I figured once they are there they wont change much, so the duplication
isn't really a maintainability issue. That was my logic :-)
