On Thu, Nov 03, 2011 at 10:56:47PM +0100, Janus Weil wrote: > > At least add a comment about the re-use (abuse?) of the > > enum. > > Updated patch attached, which adds a short comment on the usage of 'match'.
Thanks. > > This should reduce confusion months from when > > someone wonders why gfc_extend_expr returns a "match" > > for a non-matching function. > > Well, I think my approach is not as far-fetched as you seem to imply: > There are already a good number of procedures which use the 'match' > enum, although they're not related to matching at all. Listing only > those that occur in gfortran.h (I'm sure there are more): > > * match gfc_mod_pointee_as (gfc_array_spec *); > * match gfc_intrinsic_func_interface (gfc_expr *, int); > * match gfc_intrinsic_sub_interface (gfc_code *, int); > * match gfc_iso_c_sub_interface(gfc_code *, gfc_symbol *); > > The reason for this is of course that the YES/NO/ERROR triple is not > only useful in matching, but also in many other situations. > I think the patch is fine and can be committed. But, give Steven a chance to respond before committing. -- Steve
