On Wed, Sep 05, 2018 at 12:50:25PM +0100, a...@codesourcery.com wrote: > 2018-09-05 Andrew Stubbs <a...@codesourcery.com> > > gcc/ > * simplify-rtx.c (convert_packed_vector): New function. > (simplify_immed_subreg): Recognised Boolean vectors and call > convert_packed_vector. > ---
> + int elem_bitsize = (GET_MODE_SIZE (from_mode).to_constant() Further formatting nits, no space before (. > + * BITS_PER_UNIT) / num_elem; > + int elem_mask = (1 << elem_bitsize) - 1; > + HOST_WIDE_INT subreg_mask = = at the end of line. > + (sizeof (HOST_WIDE_INT) == GET_MODE_SIZE (to_mode) > + ? -1 > + : (((HOST_WIDE_INT)1 << (GET_MODE_SIZE (to_mode) * BITS_PER_UNIT)) > + - 1)); > + /* Vectors with multiple elements per byte are a special case. */ > + if ((VECTOR_MODE_P (innermode) > + && ((GET_MODE_NUNITS (innermode).to_constant() > + / GET_MODE_SIZE(innermode).to_constant()) > 1)) Missing spaces before ( several times. Jakub