On Mon, Oct 24, 2011 at 8:31 AM, Aldy Hernandez <al...@redhat.com> wrote: > On 10/21/11 15:46, Joseph S. Myers wrote: >> >> On Fri, 21 Oct 2011, Aldy Hernandez wrote: >> >>>>> X32 uses x86-64 instruction set with 32bit pointers. It has the same >>>>> atomic support as x86-64 and has atomic support for int128. >>>> >>>> Oh, you aren't talking about 32 bit, but a 32 bit abi on a 64 bit >>>> machine. >>> >>> Thanks for pointing this out Joseph. >>> >>> The following patch handles both x86_64 and i?86, but only returns true >>> for >>> LP64. Is this what you had in mind? >> >> My understanding from the x32 discussion is that the relevant condition is >> "using 64-bit instructions", not "using an LP64 ABI". That might be "! >> ia32" in effective-target terms. > > > This works for me. Do you agree? >
It looks good to me. Thanks. -- H.J.