On Wed, 2018-01-17 at 11:31 -0600, Segher Boessenkool wrote:
> On Wed, Jan 17, 2018 at 09:51:54AM -0600, Will Schmidt wrote:
> > On Tue, 2018-01-16 at 16:34 -0600, Segher Boessenkool wrote:
> > > Hi!
> > > On Tue, Jan 16, 2018 at 01:39:28PM -0600, Will Schmidt wrote:
> > > > --- /dev/null
> > > > +++ b/gcc/testsuite/gcc.target/powerpc/builtins-1-be-folded.c
> > > > @@ -0,0 +1,11 @@
> > > > +/* { dg-do compile { target { powerpc-*-* } } } */
> > > 
> > > Do you want powerpc*-*-*?  That is default in gcc.target/powerpc; dg-do
> > > compile is default, too, so you can either say
> > > 
> > > /* { dg-do compile } */
> > > 
> > > or nothing at all, to taste.
> > > 
> > > But it looks like you want to restrict to BE?  We still don't have a
> > > dejagnu thingy for that; you could put some #ifdef around it all (there
> > > are some examples in other testcases).  Not ideal, but works.
> > 
> > Just want to ensure continuing coverage.  :-)  This test in particular
> > is a copy/paste + tweak of an existing test, which tries to limit itself
> > to BE, there is an LE counterpart.
> 
> powerpc-*-* means those compilers that were configured for a 32-bit BE
> default target.  Which we do not usually have these days.  It also doesn't
> say much about what target the test is running for.
> 
> > My regression test results suggest that the addition of the
> > -mno-fold-gimple option to the existing testcases appears to have
> > uncovered an ICE, so pausing for the moment...
> 
> Good luck :-)  If you are reasonably certain the bug is not in your patch
> (but pre-existing), please do commit the patch.

Ok.  That does seem to be the case.

I'll commit this one shortly, and will do some additional follow-up on
the ICE, see if I can at least narrow it down a bit.

Thanks,
-Will

> 
> 
> Segher
> 


Reply via email to