On Sun, Jan 14, 2018 at 8:19 AM, Uros Bizjak <ubiz...@gmail.com> wrote: > On Fri, Jan 12, 2018 at 9:01 AM, Uros Bizjak <ubiz...@gmail.com> wrote: >> On Thu, Jan 11, 2018 at 2:28 PM, H.J. Lu <hjl.to...@gmail.com> wrote: >> >>> Hi Uros, >>> >>> Can you take a look at my x86 backend changes so that they are ready >>> to check in once we have consensus. >> >> Please finish the talks about the correct approach first. Once the >> consensus is reached, please post the final version of the patches for >> review. >> >> BTW: I have no detailed insight in these issues, so I'll look mostly >> at the implementation details, probably early next week. > > One general remark is on the usage of -1 as an invalid register
This has been rewritten. The checked in patch no longer does that. > number. We have INVALID_REGNUM definition for this, and many tests, > like: > > if (regno >= 0) > > could become much more informative: > > if (regno != INVALID_REGNUM) -- H.J.
