On 09/15/2017 08:48 AM, Pierre-Marie de Rodat wrote:
> On 09/15/2017 12:54 PM, Pierre-Marie de Rodat wrote:
>> I’m not super confident about this though, so I’ll resubmit a patch
>> without the reordering: I’ve added more comments anyway as I’ve
>> learned more about this since yesterday. ;-)
>
> Here it is!
>
> --
> Pierre-Marie de Rodat
>
> 0001-Add-comments-to-struct-cgraph_thunk_info.patch
>
>
> From 601dd0e949f4af456a11036918da9dbadbb3aa0c Mon Sep 17 00:00:00 2001
> From: Pierre-Marie de Rodat <dero...@adacore.com>
> Date: Wed, 13 Sep 2017 16:21:04 +0200
> Subject: [PATCH] Add comments to struct cgraph_thunk_info
>
> This commit adds comments to fields in the cgraph_thunk_info structure
> declaration from cgraph.h. They will hopefully answer questions that
> people like myself can ask while discovering the thunk machinery. I
> also made an assertion stricter in cgraph_node::create_thunk.
>
> Bootsrapped and regtested on x86_64-linux.
>
> gcc/
>
> * cgraph.h (cgraph_thunk_info): Add comments.
> * cgraph.c (cgraph_node::create_thunk): Adjust comment, make
> assert for VIRTUAL_* arguments stricter.
OK.
jeff
