On 09/14/2017 02:01 AM, Pierre-Marie de Rodat wrote: > Hello, > > This commit adds comments to fields in the cgraph_thunk_info structure > declaration from cgraph.h. They will hopefully answer questions that > people like myself can ask while discovering the thunk machinery. I > also made an assertion stricter in cgraph_node::create_thunk. > > I'm adding Nathan in copy as we discussed this thunk matter at this > year's Cauldron. :-) > > Bootsrapped and regtested on x86_64-linux. Ok to commit? Thank you in > advance! > > gcc/ > > * cgraph.h (cgraph_thunk_info): Add comments, reorder fields. > * cgraph.c (cgraph_node::create_thunk): Adjust comment, make > assert for VIRTUAL_* arguments stricter. The comment additions are fine. What's the rationale behind the ordering of the fields? In general we want the opposite order from what you did -- going from most strictly aligned to least strictly aligned minimizes the amount of unused padding.
jeff
