On Tue, Jun 13, 2017 at 1:15 PM, Bin.Cheng <amker.ch...@gmail.com> wrote: > On Tue, Jun 13, 2017 at 12:06 PM, Richard Biener > <richard.guent...@gmail.com> wrote: >> On Mon, Jun 12, 2017 at 7:02 PM, Bin Cheng <bin.ch...@arm.com> wrote: >>> Hi, >>> This simple patch computes and preserves loop nest vector for whole >>> distribution >>> life time. The loop nest will be used multiple times in on-demand data >>> dependence >>> computation. >>> >>> Bootstrap and test on x86_64 and AArch64. Is it OK? >> >> Don't like it too much but I guess we can see if refactoring it back >> to pass down >> loop_nest can work. > The global data is partly to avoid patch conflicts when separating > patches, otherwise several parameters are needed for quite number of > functions. We can introduce a global distribution data and only pass > it to various functions.
Or make a class covering distribution of one loop (nest) and make all functions members ... struct one_loop_distribution { one_loop_distribution (loop *); ... }; Richard. > Thanks, > bin >> >> Ok. >> >> Thanks, >> Richard. >> >>> Thanks, >>> bin >>> 2017-06-07 Bin Cheng <bin.ch...@arm.com> >>> >>> * tree-loop-distribution.c (loop_nest): New global var. >>> (build_rdg): Use loop directly, rather than loop nest. >>> (pg_add_dependence_edges): Remove loop nest parameter. Use global >>> variable directly. >>> (distribute_loop): Compute global variable loop nest. Update use.