On Tue, Jun 13, 2017 at 1:06 PM, Richard Biener <richard.guent...@gmail.com> wrote: > On Mon, Jun 12, 2017 at 7:02 PM, Bin Cheng <bin.ch...@arm.com> wrote: >> Hi, >> This simple patch computes and preserves loop nest vector for whole >> distribution >> life time. The loop nest will be used multiple times in on-demand data >> dependence >> computation. >> >> Bootstrap and test on x86_64 and AArch64. Is it OK? > > Don't like it too much but I guess we can see if refactoring it back > to pass down > loop_nest can work. > > Ok.
Oh. +/* The loop (nest) to be distributed. */ +static vec<loop_p> *loop_nest; + please make it static vec<loop_p> loop_nest; instead to avoid a pointless indirection (vec<> just contains a pointer to allocated storage). Richard. > Thanks, > Richard. > >> Thanks, >> bin >> 2017-06-07 Bin Cheng <bin.ch...@arm.com> >> >> * tree-loop-distribution.c (loop_nest): New global var. >> (build_rdg): Use loop directly, rather than loop nest. >> (pg_add_dependence_edges): Remove loop nest parameter. Use global >> variable directly. >> (distribute_loop): Compute global variable loop nest. Update use.
