2017-05-02 12:21 GMT+02:00 JonY <10wa...@gmail.com>: > On 05/01/2017 11:31 AM, Uros Bizjak wrote: >> On Thu, Apr 27, 2017 at 10:04 AM, Daniel Santos <daniel.san...@pobox.com> >> wrote: >>> All of patches are concerned with 64-bit Microsoft ABI functions that call >>> System V ABI function which clobbers RSI, RDI and XMM6-15 and are aimed at >>> improving performance and .text size of Wine 64. I had previously submitted >>> these as separate patch sets, but have combined them for simplicity. (Does >>> this make the ChangeLogs too big? Please let me know if you want me to break >>> these back apart.) Below are the included patchsets and a summary of changes >>> since the previous post(s): >> >> Well, the ChangeLog is acceptable. >> >> I have comments on how new RTX patterns are generated and checked >> (patches 9/12 and 11/12). Other patches look good to me, so after >> issues with 9/12 and 11/12 are resolved, I think the patch set is >> ready to go. >> >> After the above issue is addressed, I propose to move forward by >> committing the patchset, and resolve any possible issues later. There >> are just too many code paths in the stack frame construction and >> teardown to notice all possible interactions between new and old code. >> It looks that existing code won't be affected without activating new >> option, so we can be a bit less cautious with the patchset. An >> important part is thus a comprehensive added test suite, which seems >> to pass. >> >> I also assume that Cygwin and MinGW people agree with the patch and >> the functionality itself. >> >> Uros. >> > > Cygwin and MinGW does not use SysV/MS transitions directly in their own > code, changes should be OK. > > >
Right, and Wine people will tell, if something doesn't work for them. So ok for me too. Kai
