On 04/28/2017 01:41 PM, Nathan Sidwell wrote: > On 04/25/2017 09:08 AM, marxin wrote: >> gcc/ChangeLog: >> >> 2017-04-26 Martin Liska <mli...@suse.cz> >> >> PR gcov-profile/79891 >> * gcov.c (add_line_counts): Assign BBs to lines just if the BB >> is marked by compiler as living on a line. >> (get_cycles_count): Remove usage of the union. >> (output_intermediate_file): Likewise. >> (find_source): Fix GNU coding style. >> (accumulate_line_counts): Remove old non-all block mode. >> (output_lines): Remove usage of the union. >> * profile.c (output_location): Include all BBs, even if >> belonging to a same line (and file) as a previous BB. >> > > >> @@ -2269,32 +2262,32 @@ add_line_counts (coverage_t *coverage, function_t >> *fn) >> block->cycle.arc = NULL; >> block->cycle.ident = ~0U; >> + if (!has_any_line) >> + has_any_line = true; > > You know, you're allowed to set a true bool to true :)
Heh, stupid mistake. Actually, can be funny warning candidate. I guess I'm not first who did it. > > Could you annotate the testcase with what the original problem was? Sure, however I do not expect any PRs related to this commit. No, I'm kidding, the patch make a significant changes :) Martin > I think that'll help a future regression investigator. > > otherwise ok. > > nathan >
