On Mon, 24 Apr 2017, Bernd Edlinger wrote:
> On 04/24/17 09:00, Richard Biener wrote:
> > On Fri, 21 Apr 2017, Bernd Edlinger wrote:
> >
> >> Hi!
> >>
> >>
> >> This removes some dead and unreachable code in c_common_get_alias_set:
> >> Because cc1 was recently changed to be only called with one file at a
> >> time, the code after "if (num_in_fnames == 1) return -1;" is no longer
> >> reachable, and can thus be removed.
> >
> > While I think you are correct it looks like c_common_parse_file still
> > happily parses multiple infiles. That is, only for
> > flag_preprocess_only we have a
> >
> > if (num_in_fnames > 1)
> > error ("too many filenames given. Type %s --help for usage",
> > progname);
> >
> > and:
> >
> > gcc> ./cc1 -quiet t.c t2.c
> > t2.c:5:6: error: conflicting types for ‘bar’
> > void bar () { struct X x; *(volatile char *)x.buf = 1; }
> > ^~~
> > t.c:8:1: note: previous definition of ‘bar’ was here
> > bar (int x)
> > ^~~
> >
> > which means it actually still "works" to combine two source files
> > (yes, the driver no longer seems to have the ability to pass down
> > multiple inputs to cc1).
> >
> > Thus, can you first remove that "feature"?
> >
>
> Yes, sure. See updated patch.
Ok.
Thanks,
Richard.
