On Wed, Sep 14, 2011 at 10:38 PM, Richard Henderson <r...@redhat.com> wrote:
> On 09/13/2011 04:27 PM, Michael Meissner wrote:
>> This patch touches a bunch of files, but most of the changes are fairly
>> mechanical.  What this does is change the infrastructure of how machine
>> independent builtin functions are handled.  At this point, there is no change
>> to the compiler from a user perspective.  Instead of having two parallel 
>> arrays
>> that have tree pointers for built-in functions:
>>
>>       built_in_decls
>>       implicit_built_in_decls
>>
>> I have replaced these by two macros that call inline functions:
>>
>>       BUILT_IN_DECLS
>>       IMPLICIT_BUILT_IN_DECLS
>>
>> and changed the other parts that want to modify the builtins.  By changing it
>> to a functional approach instead of an array, we can more easily change the
>> code underneath.
>
> Why bother with the case change and poisoning?  Merely changing the type of 
> the symbol from object to function ought to be sufficient to catch all users 
> at compile time.
>
> I say this because I'm not keen on functions using all-caps names...

Yeah, I agree.

Richard.

>
> r~
>

Reply via email to