On Wed, 2017-03-15 at 14:53 +0100, Martin Liška wrote:
> Hello.
>
> Following small series exclude some strings from pot files via
> introduction of internal_error_cont function.
>
> Patch can bootstrap and survives regression tests.
>
> (Sorry for broken threading because my cover letter was rejected).
>
> Martin
>
> marxin (3):
> Introduce internal_error_cont function and use it in cfgrtl.c (PR
> rtl-optimization/79856).
> Replace error with internal_error_cont in cgraph.c (PR ipa/79857).
> Regenerate gcc.pot.
>
> gcc/cfgrtl.c | 349 +-
> gcc/cgraph.c | 139 +-
> gcc/diagnostic-core.h | 1 +
> gcc/diagnostic.c | 16 +
> gcc/diagnostic.def | 1 +
> gcc/po/exgettext | 6 +-
> gcc/po/gcc.pot | 14892 ++++++++++++++++++++++++-------------
> -----------
> 7 files changed, 7589 insertions(+), 7815 deletions(-)
[For some reason I only received the 0/3 and 3/3 mail, not 1/3 and 2/3]
In patch 1:
2017-03-13 Martin Liska <mli...@suse.cz>
PR rtl-optimization/79856
* cfgrtl.c (try_redirect_by_replacing_jump): Fix GNU coding
style.
(fixup_partition_crossing): Likewise.
(fixup_new_cold_bb): Likewise.
(emit_barrier_after_bb): Likewise.
(force_nonfallthru_and_redirect): Likewise.
(last_bb_in_partition): Likewise.
(rtl_split_edge): Likewise.
(commit_one_edge_insertion): Likewise.
(print_rtl_with_bb): Likewise.
(find_partition_fixes): Use internal_error_cont instead of
error.
(verify_hot_cold_block_grouping): Likewise.
(rtl_verify_edges): Likewise.
(rtl_verify_bb_insns): Likewise.
(rtl_verify_bb_pointers): Likewise.
(rtl_verify_bb_insn_chain): Likewise.
(rtl_verify_fallthru): Likewise.
(purge_dead_edges): Fix GNU coding style.
(fixup_abnormal_edges): Likewise.
(fixup_reorder_chain): Likewise.
(duplicate_insn_chain): Likewise.
* diagnostic-core.h (internal_error_cont): Declare new
function.
* diagnostic.c (diagnostic_action_after_output): Handle
newly added DK_INTERNAL_ERROR.
(internal_error_cont): New function.
* diagnostic.def (DK_INTERNAL_ERROR): New enum value.
...the cfgrtl.c changes are a mixture of hunks that are (mostly)
whitespace fixes, combined with hunks that move over to using
internal_error_cont.
Please can you split this patch up to move the cfgrtl.c coding style
fixes into a separate patch, since this obscures the diagnostic
changes?
Also, as Joseph notes, if a function accepts a string param that isn't
to be translated, don't use "gmsgid" or "msgid" as the param name (just
call it "msg" or somesuch).
Thanks
Dave
