On Wed, Jan 25, 2017 at 6:07 PM, Thomas Schwinge <tho...@codesourcery.com> wrote: > Hi! > > On Wed, 25 Jan 2017 13:21:13 +0100, Jakub Jelinek <ja...@redhat.com> wrote: >> On Wed, Jan 25, 2017 at 11:00:50AM +0100, Thomas Schwinge wrote: >> > On Tue, 24 Jan 2017 13:52:10 +0100, Martin Jambor <mjam...@suse.cz> wrote: >> > > [BRIG front end] > > $ git grep --cached libbrig > gcc/brig/config-lang.in:target_libs="target-libbrig target-libhsail-rt" > > What is "libbrig"; should we remove that (as far as I can tell?) stale > reference?
Yes, a leftover that can be removed. > $ git show 55a56509bb4ae0c844c27f0679a22844bed3a3c5 -- libhsail-rt/README > | filterdiff > --- /dev/null > +++ libhsail-rt/README > @@ -0,0 +1,4 @@ > +Run autoconf2.64 && automake-1.11 to regenerate the buildfiles. > +You might need to manually tweak the minor automake version number > +in configure.ac and aclocal.m4 (search for 1.11.6) in case your > +local 1.11 minor version doesn't match. > \ No newline at end of file > > I don't understand that "manually tweak" comment -- you should just > install/build the right versions, and run "PATH=[...]:$PATH autoreconf", > which is the same for all GCC subdirectories. OK. I'll remove that. IIRC, I had some difficulties with getting the exact minor versions of autotools working together, and found out that the minor version didn't matter here, so left this as a note. > Instead, the README file should contain a note what the "libhsail-rt" > directory is about. OK, I will add a note. > $ git show 55a56509bb4ae0c844c27f0679a22844bed3a3c5 -- > gcc/builtin-types.def | filterdiff --hunks=1 > diff --git gcc/builtin-types.def gcc/builtin-types.def > index 91745b4..ee6d052 100644 > --- gcc/builtin-types.def > +++ gcc/builtin-types.def > @@ -67,7 +67,10 @@ DEF_PRIMITIVE_TYPE (BT_LONGLONG, > long_long_integer_type_node) > DEF_PRIMITIVE_TYPE (BT_ULONGLONG, long_long_unsigned_type_node) > DEF_PRIMITIVE_TYPE (BT_INTMAX, intmax_type_node) > DEF_PRIMITIVE_TYPE (BT_UINTMAX, uintmax_type_node) > -DEF_PRIMITIVE_TYPE (BT_UINT16, uint16_type_node) > +DEF_PRIMITIVE_TYPE (BT_INT8, signed_char_type_node) > +DEF_PRIMITIVE_TYPE (BT_INT16, short_integer_type_node) > +DEF_PRIMITIVE_TYPE (BT_UINT8, char_type_node) > +DEF_PRIMITIVE_TYPE (BT_UINT16, short_unsigned_type_node) > DEF_PRIMITIVE_TYPE (BT_UINT32, uint32_type_node) > DEF_PRIMITIVE_TYPE (BT_UINT64, uint64_type_node) > DEF_PRIMITIVE_TYPE (BT_WORD, (*lang_hooks.types.type_for_mode) > (word_mode, 1)) > > Is that change alright? For instance, uint16_type_node is still used > elsewhere. Some of these intN/uintN type_nodes apparently don't exist as > global_trees; should they, and then be referred to here instead of the > C-like type_nodes? Yes, it makes sense. I will fix and test this. > The "News" section on <https://gcc.gnu.org/>, and > <https://gcc.gnu.org/gcc-7/changes.html> should also be updated, I guess? > :-) Yes, of course. I will provide text. > I suppose that also contrib/update-copyright.py need to be updated? (I > never looked into that, so don't know.) Does it? The files are (c) FSF now. What should I do here exactly? BR, Pekka
