On Thu, 12 Jan 2017 15:39:54 PST (-0800), jos...@codesourcery.com wrote: > Have these changes been sent upstream? Although at the present > development stage applying selected changes might be better than a bulk > merge from upstream libsanitizer, they should still go upstream so they > aren't a local patch at the time of the next merge.
Sorry, I didn't know there was an upstream to this. I went to send this upstream to the LLVM compiler-rt repo, but I think this port is actually broken: it turns out we hadn't built it in a while (which is why the double-&& wasn't noticed, it must have come from a rebase) and it looks like we don't quite have a sane set of Linux headers right now so we don't quite match up with the SANITIZER_USES_CANONICAL_LINUX_SYSCALLS macro any more. I think it'd be best if we just drop this for now and wait for our Linux port to stabilize a bit (which we're planning on doing after the GCC code reviews). There's a bit too much stuff in flight for me to be able to keep track of it all right now. Sorry! Also, thanks for finding the "&& &&" bug -- I hadn't noticed we weren't compiling libsanitizer any more.
