On Thu, Jan 12, 2017 at 1:38 PM, Joseph Myers <jos...@codesourcery.com> wrote:
> On Wed, 11 Jan 2017, Palmer Dabbelt wrote:
>
>> +#include <stdint.h>
>
> This is included in system.h, so don't include it here.
OK.
>
>> + error ("unknown cpu `%s' for -mtune", cpu_string);
>
> This is using very-old-style `' quotes. Diagnostics should use e.g. %qs
> for quoting the output of a single % directive, or %< and %> for quoting
> anything more complicated, so that Unicode quotes can be used when the
> locale permits.
>
> Likewise elsewhere in this patch and in patch 2.
Will do, throughout.
>
>> +#undef TARGET_LRA_P
>> +#define TARGET_LRA_P hook_bool_void_true
>
> Using LRA is the default; you shouldn't need this definition.
Ah, glad to see LRA is now the default.
>
> I don't see a definition of TARGET_ATOMIC_ASSIGN_EXPAND_FENV. Since you
> have floating-point exceptions, I'd expect lack this to result in
> c11-atomic-exec-5.c failing.
Indeed, and after implementing the hook, those failures disappeared. Thanks.
>
> --
> Joseph S. Myers
> jos...@codesourcery.com
