On Tue, Nov 29, 2016 at 05:47:08PM -0800, Cesar Philippidis wrote:
> On 11/18/2016 03:24 AM, Jakub Jelinek wrote:
> > On Sat, Nov 12, 2016 at 08:51:00AM -0800, Cesar Philippidis wrote:
> >> On 11/11/2016 02:34 AM, Jakub Jelinek wrote:
> >>> On Thu, Nov 10, 2016 at 06:46:46PM +0800, Chung-Lin Tang wrote:
> >>
> >> And here's the patch.
> >
> > The patch doesn't look like OpenACC tile clause fortran support,
> > but bind/nohost clause C/C++ support.
>
> I think I got that patch mixed up with the acc routines patch. Here is
> the fortran tile clause patch.
>
> One notable difference between the trunk and gomp4 implementation of the
> tile clause is that gomp4 errors on negative value tile arguments,
> whereas trunk issues warnings. Is there a reason why the fortran FE
> generally emits a warning, on say num_threads(-5), instead of an error?
>
> Chung-Lin, I noticed in your source tree that you included a change to
> gfortranspec.c. Is that necessary for trunk? I've included in this patch
> just in case the other tile patches require it.
This is ok for trunk without the gfortranspec.c hunk (please remove it also
from the ChangeLog entry).
> 2016-11-29 Cesar Philippidis <ce...@codesourcery.com>
> Joseph Myers <jos...@codesourcery.com>
>
> gcc/fortran/
> * gfortranspec.c (lang_specific_pre_link): Update call to do_spec.
> * openmp.c (resolve_omp_clauses): Error on directives
> containing both tile and collapse clauses.
> (resolve_oacc_loop_blocks): Represent '*' tile arguments as zero.
> * trans-openmp.c (gfc_trans_omp_do): Lower tiled loops like
> collapsed loops.
>
> gcc/testsuite/
> * gfortran.dg/goacc/combined-directives.f90: Remove xfail.
> * gfortran.dg/goacc/tile-1.f90: New test.
> * gfortran.dg/goacc/tile-2.f90: New test.
> * gfortran.dg/goacc/tile-lowering.f95: New test.
Jakub
