On Fri, 9 Dec 2016, Jakub Jelinek wrote:
> Can you post an incremental patch fixing those issues?
A few small nits I found while reading the patch.
First of all, please use 'git diff --patience' (or --histogram) when
generating such patches, without it the changes in omp-low.c look uglier than
necessary.
The comment for 'struct oacc_loop' in new file omp-device.c is misplaced: for
some reason it's above the #include block.
This patch doesn't seem to apply to current trunk due to a conflict in
cp/parser.c. If you could create a git branch (perhaps in your personal
namespace so you can freely rebase it) with this patchset, I'd appreciate it.
When trying to apply the patch, git notes a few remaining whitespace issues:
$ zcat 0001-Split-omp-low-into-multiple-files.patch.gz | git apply --reject -
<stdin>:2734: space before tab in indent.
# BLOCK 2 (PAR_ENTRY_BB)
<stdin>:5346: space before tab in indent.
true, GSI_SAME_STMT);
<stdin>:8129: space before tab in indent.
after a stmt, not before. */
<stdin>:9060: space before tab in indent.
GOMP_atomic_start ();
<stdin>:9061: space before tab in indent.
*addr = rhs;
Hope this helps.
Alexander
