On Nov 18, 2016, at 4:33 AM, Iain Sandoe <iain_san...@mentor.com> wrote: > > As discussed on IRC, I was under the impression that it is desired to move > away from #ifdef towards if() and I have been adding those where locally > things have been touched - in this case it was only partially possible. > > However, FAOD - you pointed out that for the RS6000 back-end #ifdef are still > preferred,
Shudder. We can encourage anyone that likes #if, to like if () instead. > OK now for trunk? Ok; I'm pretty sure that change can only impact darwin. If you wanted to reduce the test case to 3 cases, I think that would also show the problem that show that your patch fixes it, ok with such a change, if you want. > Open branches? I'm fine with back porting.