On Fri, Sep 09, 2011 at 11:56:29AM -0700, Iyer, Balaji V wrote:
> diff --git a/gcc/ChangeLog.cilk b/gcc/ChangeLog.cilk index 8880b0a..299febb
> 100644
> --- a/gcc/ChangeLog.cilk
> +++ b/gcc/ChangeLog.cilk
> @@ -2,6 +2,9 @@
>
> * gimplify.c (gimplify_call_expr): Removed if (SPAWN_CALL_P (*expr))
> statement.
> + * tree.c (walk_tree_1): Added "case CILK_FOR_STMT:".
> + * tree.h (CILK_FOR_VAR): Changed TREE_OPERAND(..., 4) to
> + TREE_OPERAND(..., 5).
The above is still not correct ChangeLog, you are quoting the actual code
way too much. E.g. the second could be:
* tree.c (walk_tree_1): Handle CILK_FOR_STMT.
third maybe:
* tree.c (CILK_FOR_VAR): Use 5 instead of 4 as last TREE_OPERAND
argument.
The first one should describe what kind of code you've actually removed,
Don't handle this or that.
etc.
> +2011-09-08 Balaji V. Iyer <balaji.v.i...@intel.com>
> +
> + * cp-tree.h (FOR_SCOPE): Changed FOR_STMT_CHECK to FOR_STMT_CHECK2
All ChangeLog entries end with a dot.
> + * cilk.c (check_incr): Added a check for variable entity name match,
> not just
> + var. Removed the assert to check if operand 0 is the variable.
Two spaces after . in between sentences.
Jakub
