On Thu, Sep 8, 2011 at 8:30 PM, Iyer, Balaji V <balaji.v.i...@intel.com> wrote:
> Hello Everyone,
> This patch is for the Cilk Plus branch GCC C++ compiler. It will fix
> the following cases of cilk_for (where 'T' is a template type)
>
> _Cilk_for ( T ii = <INITIAL VALUE> ; ii <RELATIONAL_OPERATOR> <END_VALUE> ;
> ii <+/->= <INCREMENT/DECREMENT VALUE>)
> <statement>
>
+ * cilk.c (check_incr): added "&& (TREE_OPERAND (incr, 0) !=
^ Should be 'A'.
+ DECL_NAME (var))" to if (TREE_OPERAND(incr, 0) != var) and to the outer
+ else if statements. Also removed gcc_assert (TREE_OPERAND (incr, 0) ==
+ var) from the body of both of these statements.
Can you find better description without quoting sources?
- if (TREE_OPERAND (incr, 0) != var)
+ if ((TREE_OPERAND (incr, 0) != var) &&
^^^^ It should be on the next line.
+ (DECL_NAME (TREE_OPERAND (incr, 0)) != DECL_NAME (var)))
Please remove the extra (). You have many extra () in your change.
All the trailing && and || should be on the next line.
+ * g++.dg/cilk-plus/template_cilk_for_plus_equal.cpp: New
Please add' the missing period and create a separate entry.
--
H.J.
