On Tue, Nov 01, 2016 at 10:49:10AM +0000, Jiong Wang wrote: > >>>Is this ok for trunk? > >>> > >>>Thanks, > >>>Kyrill > >>> > >>>2016-10-12 Kyrylo Tkachov <kyrylo.tkac...@arm.com> > >>> > >>> * config/aarch64/aarch64.c (aarch64_register_saved_on_entry): Add > >>> function comment. > >>> (aarch64_next_callee_save): Likewise. > >>> (aarch64_pushwb_single_reg): Likewise. > >>> (aarch64_gen_storewb_pair): Likewise. > >>> (aarch64_push_regs): Likewise. > >>> (aarch64_gen_loadwb_pair): Likewise. > >>> (aarch64_pop_regs): Likewise. > >>> (aarch64_gen_store_pair): Likewise. > >>> (aarch64_gen_load_pair): Likewise. > >>> (aarch64_save_callee_saves): Likewise. > >>> (aarch64_restore_callee_saves): Likewise. > > I "contributed" some of these functions without comments... > The new added comments looks good to me though I can't approve. > > Thanks for fixing these.
Thanks Jiong, I appreciate you taking the time to look. This is OK based on Jiong's technical review and after a glance to ensure the comments made sense to me. Thanks, James
