On 31/10/16 12:10, Kyrill Tkachov wrote:
Ping.

Thanks,
Kyrill

On 24/10/16 12:30, Kyrill Tkachov wrote:
Ping.
https://gcc.gnu.org/ml/gcc-patches/2016-10/msg00839.html

Thanks,
Kyrill

On 12/10/16 11:23, Kyrill Tkachov wrote:
Hi all,

I'm looking at the aarch64 prologue and epilogue generation code and I noticed many of the helper functions don't have function comments so it makes it harder than it has to to understand what's going on. This patch adds function comments to some of them. I hope I understood the functions correctly.

Is this ok for trunk?

Thanks,
Kyrill

2016-10-12  Kyrylo Tkachov  <kyrylo.tkac...@arm.com>

    * config/aarch64/aarch64.c (aarch64_register_saved_on_entry): Add
    function comment.
    (aarch64_next_callee_save): Likewise.
    (aarch64_pushwb_single_reg): Likewise.
    (aarch64_gen_storewb_pair): Likewise.
    (aarch64_push_regs): Likewise.
    (aarch64_gen_loadwb_pair): Likewise.
    (aarch64_pop_regs): Likewise.
    (aarch64_gen_store_pair): Likewise.
    (aarch64_gen_load_pair): Likewise.
    (aarch64_save_callee_saves): Likewise.
    (aarch64_restore_callee_saves): Likewise.

I "contributed" some of these functions without comments...
The new added comments looks good to me though I can't approve.

Thanks for fixing these.

Regards,
Jiong

Reply via email to