On Wed, 26 Oct 2016, Bin.Cheng wrote:
Thanks for reviewing, updated patch attached. Is it OK?
+/* (convert (minmax ((convert (x) c)))) -> minmax (x c) if x is promoted + and the outer convert demotes the expression back to x's type. */ +(for minmax (min max) + (simplify + (convert (minmax@0 (convert @1) INTEGER_CST@2)) + (if (types_match (@1, type) && int_fits_type_p (@2, type) + && TYPE_PRECISION (TREE_TYPE (@0)) > TYPE_PRECISION (TREE_TYPE (@1))) + (minmax @1 (convert @2))))) Don't you have a problem if @1 is signed but not @0? (int)max((unsigned long)(-2),3ul) seems to satisfy your conditions, but is not the same as max(-2,3) -- Marc Glisse