On Fri, Oct 07, 2016 at 10:45:18AM +0200, Marek Polacek wrote:
> Ping.
>
> On Sat, Oct 01, 2016 at 04:17:22PM +0200, Marek Polacek wrote:
> > On Sat, Oct 01, 2016 at 07:17:50AM +0200, Markus Trippelsdorf wrote:
> > > On 2016.09.30 at 23:31 +0200, Marek Polacek wrote:
> > > > This PR reports a bogus -Wimplicit-fallthrough warning on the attached
> > > > test.
> > > > The problem is that last_stmt_in_scope should for GIMPLE_TRY, if the
> > > > last
> > > > statement of the eval part can't fallthrough, return this statement and
> > > > don't
> > > > warn. And the same should be true for FALLTHROUGH (). This patch
> > > > fixes it.
> > > >
> > > > Bootstrapped/regtested on x86_64-linux, ok for trunk?
> > >
> > > Try to compile the testcase without the fallthrough attribute...
> >
> > Nuts. Forgot that gimple_call_internal_p doesn't handle NULL.
> >
> > Bootstrapped/regtested on x86_64-linux and ppc64-linux, ok for trunk?
> >
> > 2016-10-01 Marek Polacek <pola...@redhat.com>
> >
> > PR c++/77803
> > * gimplify.c (last_stmt_in_scope): Add check for FALLTHROUGH ().
> >
> > * g++.dg/warn/Wimplicit-fallthrough-1.C: New test.
Ok, thanks.
Jakub
