On Sun, Oct 02, 2016 at 02:42:23PM -0400, Jason Merrill wrote: > On Sat, Oct 1, 2016 at 10:17 AM, Marek Polacek <pola...@redhat.com> wrote: > > + && (last_eval == NULL > > + || !gimple_call_internal_p (last_eval, IFN_FALLTHROUGH)) > > Isn't this still assuming that non-null last_eval must be a gcall, so > we'll get a checking ICE if it's something else?
This is the 2 operand gimple_call_internal_p, which is return (is_gimple_call (gs) && gimple_call_internal_p (gs) && gimple_call_internal_fn (gs) == fn); and thus should be fine for non-NULL last_eval. Jakub