Hi Marek,
On 27/09/16 10:44, Marek Polacek wrote:
On Tue, Sep 27, 2016 at 10:03:10AM +0200, Andreas Schwab wrote:
This breaks building with gcc-4.3.
g++ -std=gnu++98 -fno-PIE -c -DUSE_LIBUNWIND_EXCEPTIONS -g -DIN_GCC
-fno-exceptions -fno-rtti -fasynchronous-unwind-tables -W -Wall -Wwrite-strings
-Wcast-qual -Wno-format -Wmissing-format-attribute -Woverloaded-virtual
-pedantic -Wno-long-long -Wno-variadic-macros -Wno-overlength-strings
-Wno-implicit-fallthrough -DHAVE_CONFIG_H -I. -I. -I../../gcc -I../../gcc/.
-I../../gcc/../include -I../../gcc/../libcpp/include
-I../../gcc/../libdecnumber -I../../gcc/../libdecnumber/dpd -I../libdecnumber
-I../../gcc/../libbacktrace -o insn-emit.o -MT insn-emit.o -MMD -MP -MF
./.deps/insn-emit.TPo insn-emit.c
cc1plus: error: unrecognized command line option "-Wno-implicit-fallthrough"
make[3]: *** [insn-emit.o] Error 1
You're right, sorry. Should be fixed in a bit.
Marek
I'm seeing about 4 triggers of this warning in the arm backend (thus breaking
bootstrap),
mostly due to the fall through comment adding some explanation.
For example:
$SRC/gcc/config/arm/arm-builtins.c: In function 'rtx_def*
arm_expand_neon_args(rtx, machine_mode, int, int, int, tree, builtin_arg*)':
$SRC/gcc/config/arm/arm-builtins.c:2155:3: error: this statement may fall
through [-Werror=implicit-fallthrough]
}
^
$SRC/gcc/config/arm/arm-builtins.c:2159:6: note: here
case NEON_ARG_CONSTANT:
where the code is:
2156 /* Fall through - if the lane index isn't a constant then
2157 the next case will error. */
2158
2159 case NEON_ARG_CONSTANT:
Is there supposed to be no empty line between the case statement and the
comment?
Or is the comment only supposed to contain "Fall through"?
Thanks,
Kyrill
