On Sun, Sep 18, 2016 at 1:16 PM, Prathamesh Kulkarni <prathamesh.kulka...@linaro.org> wrote: > Sorry for late response. In the attached patch, I removed obstack > building on fmt, and used pp_format for formatting arg_positions by adding > specifier %I (name > chosen arbitrarily). Does that look OK ? > > However it results in following warning during gcc build and am not > sure how to fix this: > ../../gcc/gcc/c-family/c-common.c: In function ‘void > warn_for_restrict(unsigned int, vec<tree_node*, va_gc>*)’: > ../../gcc/gcc/c-family/c-common.c:13132:24: warning: unknown > conversion type character ‘I’ in format [-Wformat=]
This warning (in stage 1) happens whenever we add a new specifier, don't worry about it. + FOR_EACH_VEC_SAFE_ELT (args, i, arg) + TREE_VISITED (arg) = 0; Hmm, so you're clearing TREE_VISITED before you check the arguments and leaving it set afterward? That seems like a problem, a lot of code assumes that TREE_VISITED has been cleared already and clears it after. Jason
