On Wed, Jun 22, 2016 at 11:34:05PM +0200, Bernhard Reutner-Fischer wrote:
> >+        for m in mod[:-1]:
> >+            print "model*:\ %s|\\" % m
> >+        print 'model*:\ %s) E="%s$FLAGS" ;;' % (mod[-1], event)
> >+    print '''*)
> >+echo >&2 "Unknown CPU. Run contrib/gen_autofdo_event.py --all --script
> >to update script."
> >+    exit 1 ;;'''
> >+    print "esac"
> >+    print 'exec perf record -e $E -b "$@"'
> 
> Need to quote $E ?

There's never a space in it

> >+if ! grep -q Intel /proc/cpuinfo ] ; then
> 
> I'm surprised this even runs?

It works here

$ grep -q Intel /proc/cpuinfo ] ; echo $?
0

But will fix, thanks.

-Andi


-- 
a...@linux.intel.com -- Speaking for myself only.

Reply via email to