On Wed, Jun 22, 2016 at 11:51:17AM -0600, Jeff Law wrote:
> On 06/22/2016 06:37 AM, Andi Kleen wrote:
> >From: Andi Kleen <a...@linux.intel.com>
> >
> >Add support for profiledbootstrap with autofdo. Will be useful
> >to get better testing coverage of autofdo.
> >
> >This requires Linux perf and autofdo to be installed, only
> >really for x86_64 linux on Intel so far.
> I really think we ought to check that and give a sensible error if
> autoprofiledbootstrap is requested.

It will fail at some point in the second stage with "perf not found" or
somesuch.  Is that good enough?

> 
> What happens in a one-tree build for in the gas, gdb, binutils
> subdirectories?  Does anything special need to be done for those to
> make sure they build correctly (even if they aren't taking advantage
> of profiling data)?

I haven't tested that explicitly (is there an easy way to do that?)

But in general the perf files are handled in the same way as profile
feedback files for profiledbootstrap. If that works the perf build
should work too.

> 
> I think with a reasonable error if perf isn't available and a sense
> that we're not going to horribly break one-tree-builds this should
> be ready to install.

Thanks Jeff.

-Andi

-- 
a...@linux.intel.com -- Speaking for myself only.

Reply via email to