On 13 May 2016 at 16:47, James Greenhalgh <james.greenha...@arm.com> wrote: > On Fri, May 13, 2016 at 04:41:33PM +0200, Christophe Lyon wrote: >> On 13 May 2016 at 16:37, James Greenhalgh <james.greenha...@arm.com> wrote: >> > On Wed, May 11, 2016 at 03:23:56PM +0200, Christophe Lyon wrote: >> >> 2016-05-02 Christophe Lyon <christophe.l...@linaro.org> >> >> >> >> * gcc.target/aarch64/advsimd-intrinsics/vtst.c: Add tests >> >> for vtst_p8 and vtstq_p8. >> > >> > And vtst_p16 and vtstq_p16 too please. >> > >> > vtst_s64 >> > vtstq_s64 >> > vtst_u64 >> > vtstq_u64 are also missing (AArch64 only). >> > >> vtst_p16/vtstq_p16 are AArch64 only too, right? > > Not in my copy of: > > > http://infocenter.arm.com/help/topic/com.arm.doc.ihi0073a/IHI0073A_arm_neon_intrinsics_ref.pdf > > I see it is missing from config/arm/arm_neon.h so that's a bug in the GCC > implementation. It should be easy to resolve, map it to the same place > as vtst_u16 and vtst_s16 - this is just a bit operation which takes no > semantics from the data-type. > Maybe you have a way of automatically checking that the doc and arm_neon.h contents match? I mean: - are there other intrinsics documented, but not defined in arm_neon.h ? - are there intrinsics in arm_neon.h, but not in the doc?
> Would you mind spinning the fix for that and committing it before this > patch? > I've attached an updated patch which contains the definition for the missing vtst_p16 and vtstq_p16, as well as tests for vtst_p8, vtstq_p8, vtst_p16 and vtstq_p16. >> My introduction message was not clear enough: this series >> only attempts to fully cover AArch32 intrinsics. > > Understood, sorry for the extra noise. > Coverage of AArch64 intrinsics will require another effort :) > Thanks, > James > >
2016-05-19 Christophe Lyon <christophe.l...@linaro.org> gcc/ * config/arm/arm_neon.h (vtst_p16, vtstq_p16): New. gcc/testsuite/ * gcc.target/aarch64/advsimd-intrinsics/vtst.c: Add tests for vtst_p8, vtstq_p8, vtst_p16 and vtstq_p16.
diff --git a/gcc/config/arm/arm_neon.h b/gcc/config/arm/arm_neon.h index 07503d7..7997cb4 100644 --- a/gcc/config/arm/arm_neon.h +++ b/gcc/config/arm/arm_neon.h @@ -2607,6 +2607,12 @@ vtst_p8 (poly8x8_t __a, poly8x8_t __b) return (uint8x8_t)__builtin_neon_vtstv8qi ((int8x8_t) __a, (int8x8_t) __b); } +__extension__ static __inline uint16x4_t __attribute__ ((__always_inline__)) +vtst_p16 (poly16x4_t __a, poly16x4_t __b) +{ + return (uint16x4_t)__builtin_neon_vtstv4hi ((int16x4_t) __a, (int16x4_t) __b); +} + __extension__ static __inline uint8x16_t __attribute__ ((__always_inline__)) vtstq_s8 (int8x16_t __a, int8x16_t __b) { @@ -2649,6 +2655,12 @@ vtstq_p8 (poly8x16_t __a, poly8x16_t __b) return (uint8x16_t)__builtin_neon_vtstv16qi ((int8x16_t) __a, (int8x16_t) __b); } +__extension__ static __inline uint16x8_t __attribute__ ((__always_inline__)) +vtstq_p16 (poly16x8_t __a, poly16x8_t __b) +{ + return (uint16x8_t)__builtin_neon_vtstv8hi ((int16x8_t) __a, (int16x8_t) __b); +} + __extension__ static __inline int8x8_t __attribute__ ((__always_inline__)) vabd_s8 (int8x8_t __a, int8x8_t __b) { diff --git a/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vtst.c b/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vtst.c index 9e74ffb..8f9e651 100644 --- a/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vtst.c +++ b/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vtst.c @@ -32,6 +32,19 @@ VECT_VAR_DECL(expected_unsigned,uint,16,8) [] = { 0x0, 0xffff, VECT_VAR_DECL(expected_unsigned,uint,32,4) [] = { 0x0, 0xffffffff, 0x0, 0xffffffff }; +/* Expected results with poly input. */ +VECT_VAR_DECL(expected_poly,uint,8,8) [] = { 0x0, 0xff, 0xff, 0xff, + 0xff, 0xff, 0xff, 0xff }; +VECT_VAR_DECL(expected_poly,uint,8,16) [] = { 0x0, 0xff, 0xff, 0xff, + 0xff, 0xff, 0xff, 0xff, + 0xff, 0xff, 0xff, 0xff, + 0xff, 0xff, 0xff, 0xff }; +VECT_VAR_DECL(expected_poly,uint,16,4) [] = { 0x0, 0xffff, 0x0, 0xffff }; +VECT_VAR_DECL(expected_poly,uint,16,8) [] = { 0x0, 0xffff, + 0x0, 0xffff, + 0xffff, 0xffff, + 0xffff, 0xffff }; + #define INSN_NAME vtst #define TEST_MSG "VTST/VTSTQ" @@ -71,12 +84,16 @@ FNNAME (INSN_NAME) VDUP(vector2, , uint, u, 8, 8, 15); VDUP(vector2, , uint, u, 16, 4, 5); VDUP(vector2, , uint, u, 32, 2, 1); + VDUP(vector2, , poly, p, 8, 8, 15); + VDUP(vector2, , poly, p, 16, 4, 5); VDUP(vector2, q, int, s, 8, 16, 15); VDUP(vector2, q, int, s, 16, 8, 5); VDUP(vector2, q, int, s, 32, 4, 1); VDUP(vector2, q, uint, u, 8, 16, 15); VDUP(vector2, q, uint, u, 16, 8, 5); VDUP(vector2, q, uint, u, 32, 4, 1); + VDUP(vector2, q, poly, p, 8, 16, 15); + VDUP(vector2, q, poly, p, 16, 8, 5); #define TEST_MACRO_NO64BIT_VARIANT_1_5(MACRO, VAR, T1, T2) \ MACRO(VAR, , T1, T2, 8, 8); \ @@ -109,6 +126,18 @@ FNNAME (INSN_NAME) CHECK(TEST_MSG, uint, 8, 16, PRIx8, expected_unsigned, CMT); CHECK(TEST_MSG, uint, 16, 8, PRIx16, expected_unsigned, CMT); CHECK(TEST_MSG, uint, 32, 4, PRIx32, expected_unsigned, CMT); + + /* Now, test the variants with poly8 and poly16 as input. */ +#undef CMT +#define CMT " (poly input)" + TEST_BINARY_OP(INSN_NAME, , poly, p, 8, 8); + TEST_BINARY_OP(INSN_NAME, , poly, p, 16, 4); + TEST_BINARY_OP(INSN_NAME, q, poly, p, 8, 16); + TEST_BINARY_OP(INSN_NAME, q, poly, p, 16, 8); + CHECK(TEST_MSG, uint, 8, 8, PRIx8, expected_poly, CMT); + CHECK(TEST_MSG, uint, 16, 4, PRIx16, expected_poly, CMT); + CHECK(TEST_MSG, uint, 8, 16, PRIx8, expected_poly, CMT); + CHECK(TEST_MSG, uint, 16, 8, PRIx16, expected_poly, CMT); } int main (void)