On Thu, Apr 14, 2016 at 11:18:59AM -0400, Jason Merrill wrote:
> On 04/14/2016 11:05 AM, Jakub Jelinek wrote:
> >On Thu, Apr 14, 2016 at 11:01:02AM -0400, Jason Merrill wrote:
> >>On 04/14/2016 10:30 AM, Marek Polacek wrote:
> >>>+ /* FIXME: this is violated by the C++ FE as discussed in PR70029, when
> >>>+ FUNCTION_*_QUALIFIED flags are set. */
> >>>+ if (0 && TYPE_MAIN_VARIANT (t) == t && ct && TYPE_MAIN_VARIANT (ct) !=
> >>>ct)
> >>
> >>How about guarding this check with flag_checking rather than disabling it
> >>entirely? That way it won't affect released compilers, and we can downgrade
> >>the PR from P1, but doesn't hide the bug.
> >
> >That will still mean people who use -fchecking will keep reporting such
> >ICEs. I think it is better to disable it and reenable after GCC 6 branches.
>
> OK.
Should I consider the patch approved or do we want to hear from Honza?
Marek
