On 08/16/2011 09:53 AM, Rainer Orth wrote:
>  actually makes some sense---so the general approach in your patch is good.
Indeed, but IMO it makes sense in general, not only for SPARC, but for
all targets that distinguish between -fpic and -fPIC.

>  The patch is okay.
You mean as is, with all the FIXME comments and stuff?  (Modulo the
gcc/ada PICFLAG issue, of course.)

Actually, you need to change PICFLAG to PICFLAGS_FOR_TARGET in gcc/ada/gcc-interface, so the patch as is is not okay. But yes, I'd leave the FIXMEs in as we aren't really 100% sure about most things. The only FIXME you can remove is perhaps the one in SPARC

+       # FIXME: This could be done everywhere -fpic and -fPIC differ.
+       case "${CFLAGS}" in
+           *-fpic*)
+               PICFLAG=-fpic
+               ;;
+           *)
+               PICFLAG=-fPIC
+               ;;
+       esac ;;

to do it for all targets (doesn't even need to be restricted to some of them).

Paolo

Reply via email to