Paolo Bonzini <bonz...@gnu.org> writes:
> On 08/15/2011 10:53 AM, Rainer Orth wrote:
>> * The general approach between libtool and libiberty differs. Unless
>> otherwise specified (PIC is the default or doesn't work for some
>> reason), libtool defaults to -fPIC, while libiberty has a strange
>> mixture of -fPIC/-fpic and nothing, without explanation and without a
>> default.
>
> I guess it's kind of historic, probably to produce smaller/faster code on
> PPC and SPARC which differentiate between -fPIC/-fpic.
>
> In general I trust libtool more, but -fPIC/-fpic differences should be more
> or less harmless, and this:
Maybe. OTOH, we might get away with -fpic for smaller libraries like
libiberty (which isn't usually built PIC anyway) or libgcc, but might
run into trouble with libgnat, which is far larger.
>> * For SPARC, libiberty/configure.ac has
>>
>> case "${CFLAGS}" in
>> *-fpic*)
>> PICFLAG=-fpic
>> ;;
>> *)
>> PICFLAG=-fPIC
>> ;;
>> esac ;;
>
> actually makes some sense---so the general approach in your patch is good.
Indeed, but IMO it makes sense in general, not only for SPARC, but for
all targets that distinguish between -fpic and -fPIC.
> The patch is okay.
You mean as is, with all the FIXME comments and stuff? (Modulo the
gcc/ada PICFLAG issue, of course.)
Thanks.
Rainer
--
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University
