On Fri, Feb 19, 2016 at 08:45:09PM +0000, Bernd Edlinger wrote: > I have still another question. > > Why are you adding braces here? > > + || (bitsize % BITS_PER_UNIT != 0) > + || (bitpos % BITS_PER_UNIT != 0)
These two are not really needed, but I've already committed the patch. > + || (compare_tree_int (DECL_SIZE (TREE_OPERAND (exp, 1)), bitsize) > + != 0))) > > I think everywhere in that function we omit braces around == terms > inside || terms even long ones. emacs users keep saying that emacs needs this to indent it properly. > || a == b > || c == d > || e == f) These are on a single line, so it is not a problem. Jakub