Le 03/12/2015 10:29, Janne Blomqvist a écrit :
On Tue, Dec 1, 2015 at 7:51 PM, Bernhard Reutner-Fischer
<rep.dot....@gmail.com> wrote:
As said, we could as well use a list of candidates with NULL as record marker.
Implementation cosmetics. Steve seems to not be thrilled by the
overall idea in the first place, so unless there is clear support by
somebody else i won't pursue this any further, it's not that i'm bored
or ran out of stuff i should do.. ;)
FWIW, I think the idea of this patch is quite nice, and I'd like to
see it in the compiler.
I like this feature as well.
I'm personally Ok with "C++-isms", but nowadays my contributions are
so minor that my opinion shouldn't carry that much weight on this
matter.
Same here.
David Malcolm suggested to move the candidate selection code to the
common middle-end infrastructure, which would move half of the so-called
"bloat" there. Steve, would that work for you?
It seems to me that the remaining C++-isms are rather acceptable.
I do agree that the vec implementation details seem overly complex for
something whose job is just the memory management of a growing (or
shrinking) vector. However, the API is consistent and self-explanatory,
and the usage of it that is made here (just a few "safe_push") is not
more complex than what would be done with a C-only API.
Mikael
