On Mon, Nov 09, 2015 at 11:42:19AM -0700, Jeff Law wrote: > On 11/09/2015 11:27 AM, Bernd Schmidt wrote: > >On 11/09/2015 05:47 PM, tbsaunde+...@tbsaunde.org wrote: > >>From: Trevor Saunders <tbsaunde+...@tbsaunde.org> > >> > >>gcc/ChangeLog: > >> > >>2015-11-09 Trevor Saunders <tbsaunde+...@tbsaunde.org> > >> > >> * defaults.h (EH_RETURN_HANDLER_RTX): New default definition. > >> * df-scan.c (df_get_exit_block_use_set): Adjust. > >> * except.c (expand_eh_return): Likewise. > > > >As I said for a previous patch series, if we go to the trouble of fixing > >up stuff like this, we might as well do it properly and turn things like > >this into a target hook. > I agree that pushing hookization further is good as well. I still think the > patch in and of itself is a step forward, even if it doesn't hookize > EH_RETURN_HANDLER_RTX.
yeah, that's more or less my thought, and this makes hookization easier since you can now mechanically add a hook for each thing in defaults.h that invokes the macro. Then for each target you can go through and replace the macro with an override of the hooks. That ends up with the macros replaced by hooks without writing a lot of patches that need to go through config-list.mk, and testing on multiple targets which imho is a giant pain, and rather slow. Trev > > jeff
