On 11/09/2015 11:34 AM, Bernd Schmidt wrote:
In general I think the _DEBUGGING_INFO patches are going to be OK,
modulo Jeff's comment about stage 1. I think they shouldn't have been
split - it causes numerous unnecessary extra changes, and the
intermediate stages look very inconsistent.
-#ifdef VMS_DEBUGGING_INFO
- else if (write_symbols == VMS_DEBUG || write_symbols ==
VMS_AND_DWARF2_DEBUG)
+ else if (VMS_DEBUGGING_INFO
+ && (write_symbols == VMS_DEBUG
+ || write_symbols == VMS_AND_DWARF2_DEBUG))
debug_hooks = &vmsdbg_debug_hooks;
-#endif
#ifdef DWARF2_LINENO_DEBUGGING_INFO
else if (write_symbols == DWARF2_DEBUG)
debug_hooks = &dwarf2_lineno_debug_hooks;
diff --git a/gcc/vmsdbgout.c b/gcc/vmsdbgout.c
index d41d4b2..6dd6878 100644
--- a/gcc/vmsdbgout.c
+++ b/gcc/vmsdbgout.c
@@ -24,7 +24,7 @@ along with GCC; see the file COPYING3. If not see
#include "coretypes.h"
#include "tm.h"
-#ifdef VMS_DEBUGGING_INFO
+#if VMS_DEBUGGING_INFO
#include "alias.h"
#include "tree.h"
#include "varasm.h"
This seems to reference vmsdbg_debug_hooks unconditionally, but as far
as I can tell the definition is still guarded by an #if? Does this compile?
There's an easy way for Trevor to find out. Build a cross for one of
the VMS targets (there's 3 defined in config-list.mk) :-)
jeff
