On 03/11/15 15:37, Trevor Saunders wrote: > On Tue, Nov 03, 2015 at 06:49:20AM -0700, Jeff Law wrote: >> On 11/03/2015 04:31 AM, tbsaunde+...@tbsaunde.org wrote: >>> From: Trevor Saunders <tbsaunde+...@tbsaunde.org> >>> >>> Hi, >>> >>> $subject, nothing refers to this header so we might as well remove it. >>> >>> tested I can still build on x86_64-linux-gnu, not that I would expect >>> anything >>> else or that it is particularly relevent, ok? >>> >>> Trev >>> >>> gcc/ChangeLog: >>> >>> 2015-11-03 Trevor Saunders <tbsaunde+...@tbsaunde.org> >>> >>> * config/arm/coff.h: Remove. >> More generally, if we have a header file that's not used, I'd consider >> removing it to be obvious-enough to commit without approval. >> >> We could/should probably do the same with unused functions, with the only >> wrinkle being things that are useful for debugging but which are otherwise >> unused should be kept around. > > I'd agree removing things that are dead is obvious, but sometimes things > are so convoluted its hard to be sure they are in fact dead, and then > its nice to have some confirmation you didn't miss something :) >
Caution is to be commended. In this sort of case, however, you can probably claim obviousness but then self-impose a pre-commit timeout: I think this is obvious but I'll wait 24 hours before committing. R. > Trev > >> >> jeff >>
